-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docker) Add platform to docker-compose command #5683
fix(docker) Add platform to docker-compose command #5683
Conversation
fce6b79
to
9fc67d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, let's wait for CI to be green before running.
@firasomrane did you test this locally on a machine?
If yes what OS and if not could you please follow https://datahubproject.io/docs/developers#deploying-local-versions to deploy your local changes and deploy datahub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@firasomrane thanks for contributing this back. Could you add the same logic to docker/quickstart.sh
as well?
tested this locally on my M2 mac. Works fine. |
488eafa
to
332445e
Compare
332445e
to
53532bb
Compare
53532bb
to
8376fbd
Compare
There are merge conflicts that need to be fixed |
Fixes #5682
(+) changing docker -> docker_cli file name to follow cli files convention.
Tested executing
python docker_cli.py
(after addingif __name__ == "__main__": quickstart()
at the end)Also fixed
docker/dev.sh
file executing./docker/dev.sh
With the fix it pulls
mysql
andneo4j
images successfully with the right architecture.Inspecting the image to verify the arch and looks good
docker image inspect mysql_image_id