Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(looker): Migrating to new browse path format #5688

Merged

Conversation

jjoyce0510
Copy link
Collaborator

@jjoyce0510 jjoyce0510 commented Aug 19, 2022

Summary

In this PR, we migrate the browse paths produced by looker sources to the new format, which does NOT mandate that the path ends with the asset's name or id. Learn more about the migration here: https://github.com/datahub-project/datahub/blob/648d10c16e2591e43b96f930997fa5490e27aa06/docs/advanced/browse-paths-upgrade.md

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions
Copy link

github-actions bot commented Aug 19, 2022

Unit Test Results (metadata ingestion)

       8 files  ±0         8 suites  ±0   58m 19s ⏱️ - 4m 33s
   708 tests ±0     705 ✔️ +1  3 💤 ±0  0  - 1 
1 418 runs  ±0  1 412 ✔️ +1  6 💤 ±0  0  - 1 

Results for commit ce15450. ± Comparison against base commit 98ee621.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Aug 19, 2022

Unit Test Results (build & test)

521 tests  ±0   521 ✔️ ±0   14m 48s ⏱️ -18s
121 suites ±0       0 💤 ±0 
121 files   ±0       0 ±0 

Results for commit ce15450. ± Comparison against base commit 98ee621.

♻️ This comment has been updated with latest results.

@maggiehays maggiehays added the product PR or Issue related to the DataHub UI/UX label Aug 22, 2022
@jjoyce0510 jjoyce0510 force-pushed the jj--migrate-browse-paths-looker branch from b44d980 to 046e95a Compare September 10, 2022 21:00
@jjoyce0510 jjoyce0510 force-pushed the jj--migrate-browse-paths-looker branch from 046e95a to ce15450 Compare September 19, 2022 19:33
@jjoyce0510 jjoyce0510 merged commit df3633e into datahub-project:master Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants