feat(model): adds properties, ownership, deprecated, institutional memory and tags as aspects for data platform instance entity #5728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…platform instance entity
…r data platform instance entity
sgomezvillamor
changed the title
maggiehays
added
community-contribution
|
@shirshanka , any feedback here? |
5 tasks
|
@hsheth2 could you help me here? what else is needed to extend the model? |
jjoyce0510
reviewed
Nov 15, 2022
| /** | ||
| * The abstracted URI, usually host and port. Uri should not include any environment specific properties. | ||
| */ | ||
| uri: optional Uri |
There was a problem hiding this comment.
Can we actually remove this? i mean - do we strictly need it?
jjoyce0510
approved these changes
Nov 15, 2022
|
We do not yet have an entity profile page in the UI for Data Platform Instance. That's something we'll have to add post this PR. |
Removing URI fields until further discussion
|
Thanks @jjoyce0510 |
5 tasks
cccs-Dustin
pushed a commit
to CybercentreCanada/datahub
that referenced
this pull request
Feb 1, 2023
…mory and tags as aspects for data platform instance entity (datahub-project#5728)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds properties, ownership, deprecated, institutional memory and tags as aspects for data platform instance entity.
We may also add the corresponding
EditableDataPlatformInstanceProperties, this would require a UI where we can view and update a Data Platform Instance entity. Does exist such a page view?I have explicitely skipped
GlossaryTermandDomainbecause those look more related to data than infrastructureChecklist