Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest): looker test connection #5768

Merged
merged 5 commits into from
Sep 6, 2022
Merged

feat(ingest): looker test connection #5768

merged 5 commits into from
Sep 6, 2022

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Aug 30, 2022

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions
Copy link

github-actions bot commented Aug 30, 2022 •
edited
Loading

Unit Test Results (build & test)

517 tests  ±0   517 ✔️ ±0   8m 23s ⏱️ - 1m 7s
121 suites ±0       0 💤 ±0 
121 files   ±0       0 ❌ ±0 

Results for commit d4a4217. ± Comparison against base commit 13f20ad.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Aug 30, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       8 files         8 suites   58m 33s ⏱️
   671 tests    666 ✔️ 3 💤 2 ❌
1 342 runs  1 334 ✔️ 6 💤 2 ❌

For more details on these failures, see this check.

Results for commit d4a4217.

♻️ This comment has been updated with latest results.

@shirshanka shirshanka added the ingestion PR or Issue related to the ingestion of metadata label Aug 30, 2022
@hsheth2 hsheth2 marked this pull request as ready for review September 1, 2022 22:32
shirshanka
shirshanka approved these changes Sep 5, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit 7e16ce0 into datahub-project:master Sep 6, 2022
shirshanka added a commit to shirshanka/datahub that referenced this pull request Sep 8, 2022
@hsheth2 @shirshanka
feat(ingest): looker - add test connection (datahub-project#5768)
6732e7b 
Co-authored-by: Shirshanka Das <[email protected]>
shirshanka added a commit to shirshanka/datahub that referenced this pull request Sep 8, 2022
@hsheth2 @shirshanka
feat(ingest): looker - add test connection (datahub-project#5768)
35c59f7 
Co-authored-by: Shirshanka Das <[email protected]>
@hsheth2 hsheth2 deleted the looker-test-connection branch December 15, 2022 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @shirshanka