Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(model, ingest): populate sizeInBytes in snowflake, fall back to table level profiling for large tables #5774

Merged
merged 1 commit into from
Sep 5, 2022
Merged

feat(model, ingest): populate sizeInBytes in snowflake, fall back to table level profiling for large tables #5774

merged 1 commit into from
Sep 5, 2022

Conversation

mayurinehate
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@mayurinehate mayurinehate force-pushed the add_storage_size_snowflake branch from 6b3d679 to 274af92 Compare August 30, 2022 14:34
@github-actions
Copy link

github-actions bot commented Aug 30, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       8 files  ±0         8 suites  ±0   55m 22s ⏱️ + 1m 38s
   661 tests ±0     658 ✔️ ±0  3 💤 ±0  0 ❌ ±0 
1 322 runs  ±0  1 316 ✔️ ±0  6 💤 ±0  0 ❌ ±0 

Results for commit a7eb63b. ± Comparison against base commit 5bf5fc2.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Aug 30, 2022 •
edited
Loading

Unit Test Results (build & test)

517 tests  ±0   515 ✔️  - 2   8m 28s ⏱️ -43s
121 suites ±0       0 💤 ±0 
121 files   ±0       2 ❌ +2 

For more details on these failures, see this check.

Results for commit a7eb63b. ± Comparison against base commit 5bf5fc2.

♻️ This comment has been updated with latest results.

@mayurinehate mayurinehate force-pushed the add_storage_size_snowflake branch 2 times, most recently from 2784a43 to 533daf5 Compare September 1, 2022 09:07
@mayurinehate mayurinehate force-pushed the add_storage_size_snowflake branch from 533daf5 to a7eb63b Compare September 1, 2022 09:33
@mayurinehate mayurinehate changed the title feat(model, ingest): add sizeInBytes in datasetProfile, populate in snowflake feat(model, ingest): populate sizeInBytes in snowflake Sep 2, 2022
@mayurinehate mayurinehate changed the title feat(model, ingest): populate sizeInBytes in snowflake feat(model, ingest): populate sizeInBytes in snowflake, fall back to table level profiling for large tables Sep 2, 2022
shirshanka
shirshanka approved these changes Sep 5, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit 4bf4236 into datahub-project:master Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mayurinehate @shirshanka