-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): add support for sampled reporting to keep logs manageable #5800
Conversation
example of report output after this change:
|
I would rather not paste the report output before this change, as it wouldn't be fair to GitHub's storage servers :) |
Unit Test Results (metadata ingestion) 8 files ± 0 8 suites ±0 57m 27s ⏱️ + 1m 17s For more details on these failures, see this check. Results for commit a95fa7f. ± Comparison against base commit af1fc8d. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not a huge fan of serializing the list into a string and embedding that in the structured report - any way we can make that a bit nicer to read?
return | ||
|
||
return super().append((self.total_elements, __object)) # type: ignore | ||
finally: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need the try..finally?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes it easier to ensure that the counter gets updated before we return from different places in the code
Only way to preserve the nice formatting of the list .. is to add additional element to the list: but that would violate typing and make it very tricky to make sure that someone doesn't trip up on this. |
Checklist