Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll issue on Glossary related entity page #5804

Conversation

Ankit-Keshari-Vituity
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@Ankit-Keshari-Vituity
Copy link
Contributor Author

related_entity

@github-actions
Copy link

github-actions bot commented Sep 1, 2022

Unit Test Results (build & test)

517 tests  ±0   517 ✔️ ±0   8m 22s ⏱️ -48s
121 suites ±0       0 💤 ±0 
121 files   ±0       0 ±0 

Results for commit 7956a63. ± Comparison against base commit 42a847c.

♻️ This comment has been updated with latest results.

@@ -117,6 +117,7 @@ function EntityActions(props: Props) {
fixedEntityTypes={Array.from(
entityRegistry.getTypesWithSupportedCapabilities(EntityCapabilityType.GLOSSARY_TERMS),
)}
isBatchAddGlossaryTermModalVisible={isBatchAddGlossaryTermModalVisible}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about any of the other batch actions? like setting domains and other bulk situations this will only fix the css issue if it's glossary terms.

@@ -10,7 +10,6 @@ import { EntityAndType } from '../../../types';

const SearchBody = styled.div`
height: 100%;
overflow-y: scroll;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing this CSS makes me nervous as this will affect many other places in the code. It appears that the only place affected by this weird double scroll situation is the glossary related entity tab, while other places using this component are totally fine.

It's because of that that I would suggest changing GlossaryRelatedEntity instead of changing this component that usually looks good.

I tested locally and if you simply change the return of GlossaryRelatedEntity.tsx from:

    return (
        <GroupAssetsWrapper>
            <Col md={24} lg={24} xl={24}>
                <EmbeddedListSearchSection
                    fixedQuery={fixedQueryString}
                    emptySearchQuery="*"
                    placeholderText="Filter entities..."
                />
            </Col>
        </GroupAssetsWrapper>
    );

to:

    return (
        <EmbeddedListSearchSection
            fixedQuery={fixedQueryString}
            emptySearchQuery="*"
            placeholderText="Filter entities..."
        />
    );

your problem is fixed

Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@anshbansal anshbansal added the product PR or Issue related to the DataHub UI/UX label Sep 8, 2022
@chriscollins3456 chriscollins3456 merged commit 5a5af68 into datahub-project:master Sep 8, 2022
hsheth2 pushed a commit to hsheth2/datahub that referenced this pull request Sep 8, 2022
shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Sep 8, 2022
shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants