-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scroll issue on Glossary related entity page #5804
Scroll issue on Glossary related entity page #5804
Conversation
@@ -117,6 +117,7 @@ function EntityActions(props: Props) { | |||
fixedEntityTypes={Array.from( | |||
entityRegistry.getTypesWithSupportedCapabilities(EntityCapabilityType.GLOSSARY_TERMS), | |||
)} | |||
isBatchAddGlossaryTermModalVisible={isBatchAddGlossaryTermModalVisible} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about any of the other batch actions? like setting domains and other bulk situations this will only fix the css issue if it's glossary terms.
@@ -10,7 +10,6 @@ import { EntityAndType } from '../../../types'; | |||
|
|||
const SearchBody = styled.div` | |||
height: 100%; | |||
overflow-y: scroll; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removing this CSS makes me nervous as this will affect many other places in the code. It appears that the only place affected by this weird double scroll situation is the glossary related entity tab, while other places using this component are totally fine.
It's because of that that I would suggest changing GlossaryRelatedEntity
instead of changing this component that usually looks good.
I tested locally and if you simply change the return of GlossaryRelatedEntity.tsx
from:
return (
<GroupAssetsWrapper>
<Col md={24} lg={24} xl={24}>
<EmbeddedListSearchSection
fixedQuery={fixedQueryString}
emptySearchQuery="*"
placeholderText="Filter entities..."
/>
</Col>
</GroupAssetsWrapper>
);
to:
return (
<EmbeddedListSearchSection
fixedQuery={fixedQueryString}
emptySearchQuery="*"
placeholderText="Filter entities..."
/>
);
your problem is fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
Checklist