feat(restore-indices): add endpoint for restore indices, add basic check for graph #5805
Conversation
Unit Test Results (metadata ingestion) 8 files ±0 8 suites ±0 55m 18s ⏱️ -43s For more details on these errors, see this check. Results for commit 418810d. ± Comparison against base commit c91e29b. ♻️ This comment has been updated with latest results. |
| rowsMigrated++; | ||
| } | ||
|
|
||
| try { |
There was a problem hiding this comment.
Remove sleep, this is unneeded. It was in historically to "guarantee a write went through", but it doesn't really make sense to do so.
| public long sendMessageMs = 0; | ||
|
|
||
| @Override | ||
| public String toString() { |
There was a problem hiding this comment.
This can also just be done with lombok
| } | ||
| } | ||
|
|
||
| public RestoreIndicesArgs setAspectName(String aspectName) { |
There was a problem hiding this comment.
Can just use @Data from lombok
There was a problem hiding this comment.
That will cause return type to be void. I wanted a builder pattern for ease of use.
New command line in case there is a diff between mysql and elastic
New command line in case there is no diff between mysql and elastic
Checklist