Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(theming): set custom favicon via env var #5810

Merged
merged 1 commit into from
Sep 2, 2022
Merged

feat(theming): set custom favicon via env var #5810

merged 1 commit into from
Sep 2, 2022

Conversation

gabe-lyons
Copy link
Contributor

Lets users set custom favicons without building new bundles!

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions
Copy link

github-actions bot commented Sep 1, 2022

Unit Test Results (build & test)

517 tests  ±0   517 ✔️ ±0   8m 11s ⏱️ -53s
121 suites ±0       0 💤 ±0 
121 files   ±0       0 ❌ ±0 

Results for commit 788de40. ± Comparison against base commit 9afda47.

@gabe-lyons gabe-lyons merged commit d75b2e8 into datahub-project:master Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gabe-lyons @jjoyce0510