Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(smoke-test): check debug arg in executor requests #5811

Merged
merged 1 commit into from
Sep 2, 2022
Merged

test(smoke-test): check debug arg in executor requests #5811

merged 1 commit into from
Sep 2, 2022

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Sep 1, 2022

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@hsheth2 hsheth2 requested a review from jjoyce0510 September 1, 2022 23:16
RyanHolstien
RyanHolstien approved these changes Sep 1, 2022
View reviewed changes
Copy link
Collaborator

@RyanHolstien RyanHolstien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this!

@github-actions
Copy link

github-actions bot commented Sep 2, 2022

Unit Test Results (build & test)

517 tests  ±0   517 ✔️ ±0   9m 38s ⏱️ + 1m 10s
121 suites ±0       0 💤 ±0 
121 files   ±0       0 ❌ ±0 

Results for commit 90bbce7. ± Comparison against base commit 4956f5a.

@anshbansal anshbansal merged commit 2a95248 into datahub-project:master Sep 2, 2022
@hsheth2 hsheth2 deleted the smoke-test-debug branch December 15, 2022 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanHolstien RyanHolstien RyanHolstien approved these changes

@jjoyce0510 jjoyce0510 Awaiting requested review from jjoyce0510

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hsheth2 @RyanHolstien @anshbansal