Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest): bigquery-beta - Fixing dependencies #5814

Merged
merged 2 commits into from
Sep 2, 2022

Conversation

treff7es
Copy link
Contributor

@treff7es treff7es commented Sep 2, 2022

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions
Copy link

github-actions bot commented Sep 2, 2022

Unit Test Results (metadata ingestion)

       8 files         8 suites   58m 50s ⏱️
   671 tests    668 ✔️ 3 💤 0
1 342 runs  1 336 ✔️ 6 💤 0

Results for commit e8b7a2d.

@github-actions
Copy link

github-actions bot commented Sep 2, 2022

Unit Test Results (build & test)

517 tests  ±0   517 ✔️ ±0   8m 19s ⏱️ ±0s
121 suites ±0       0 💤 ±0 
121 files   ±0       0 ±0 

Results for commit e8b7a2d. ± Comparison against base commit 2a95248.

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@treff7es treff7es changed the title fix(ingest): bigquery-beat - Fixing dependencies fix(ingest): bigquery-beta - Fixing dependencies Sep 2, 2022
Copy link
Collaborator

@anshbansal anshbansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anshbansal anshbansal merged commit c91e29b into datahub-project:master Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants