Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(frontend): download node only when USE_SYSTEM_NODE is set to false #5817

Merged
merged 2 commits into from
Sep 2, 2022
Merged

fix(frontend): download node only when USE_SYSTEM_NODE is set to false #5817

merged 2 commits into from
Sep 2, 2022

Conversation

szalai1
Copy link
Contributor

@szalai1 szalai1 commented Sep 2, 2022

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

treff7es
treff7es approved these changes Sep 2, 2022
View reviewed changes
Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions
Copy link

github-actions bot commented Sep 2, 2022

Unit Test Results (build & test)

517 tests  ±0   517 ✔️ ±0   9m 28s ⏱️ + 1m 15s
121 suites ±0       0 💤 ±0 
121 files   ±0       0 ❌ ±0 

Results for commit 1bf84ca. ± Comparison against base commit b643b34.

@treff7es treff7es merged commit 5d61924 into datahub-project:master Sep 2, 2022
@szalai1 szalai1 deleted the szalai1-fixe-arm64-node-build branch September 2, 2022 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treff7es treff7es treff7es approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@szalai1 @treff7es