Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest):looker - reduce mem usage, misc reporting improvements #5823

Merged
merged 1 commit into from
Sep 4, 2022
Merged

feat(ingest):looker - reduce mem usage, misc reporting improvements #5823

merged 1 commit into from
Sep 4, 2022

Conversation

shirshanka
Copy link
Contributor

@shirshanka shirshanka commented Sep 4, 2022 •
edited
Loading

Main improvements:

  • Memory usage reduced significantly
  • All api access funneled through a single class
  • More streamlined incremental progress and reporting

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@shirshanka shirshanka requested a review from hsheth2 September 4, 2022 21:57
@github-actions
Copy link

github-actions bot commented Sep 4, 2022

Unit Test Results (metadata ingestion)

       8 files         8 suites   58m 15s ⏱️
   671 tests    668 ✔️ 3 💤 0 ❌
1 342 runs  1 336 ✔️ 6 💤 0 ❌

Results for commit 9448811.

@github-actions
Copy link

github-actions bot commented Sep 4, 2022

Unit Test Results (build & test)

517 tests   517 ✔️  8m 24s ⏱️
121 suites      0 💤
121 files        0 ❌

Results for commit 9448811.

hsheth2
hsheth2 approved these changes Sep 4, 2022
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left two minor nits - can be fixed in a follow-up PR

metadata-ingestion/src/datahub/ingestion/source/looker/looker_common.py
@@ -1,16 +1,17 @@
from __future__ import print_function
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit - don't need this line

metadata-ingestion/src/datahub/ingestion/source/looker/looker_lib_wrapper.py
self.client_stats = LookerAPIStats()

@staticmethod
def __fields_mapper(fields: Union[str, List[str]]) -> str:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit - double leading underscore has a special meaning in python; a single underscore would be stylistically correct

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack

@shirshanka shirshanka merged commit 84b279a into datahub-project:master Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shirshanka @hsheth2