Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): presto-on-hive - Fixing mysql filter #5825

Merged
merged 2 commits into from
Sep 6, 2022
Merged

fix(ingest): presto-on-hive - Fixing mysql filter #5825

merged 2 commits into from
Sep 6, 2022

Conversation

treff7es
Copy link
Contributor

@treff7es treff7es commented Sep 5, 2022

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

szalai1
szalai1 approved these changes Sep 5, 2022
View reviewed changes
Copy link
Contributor

@szalai1 szalai1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but I don't have approve rights :S

@github-actions
Copy link

github-actions bot commented Sep 5, 2022

Unit Test Results (metadata ingestion)

       8 files         8 suites   49m 54s ⏱️
   671 tests    662 ✔️ 3 💤 0 ❌ 6 🔥
1 342 runs  1 330 ✔️ 6 💤 0 ❌ 6 🔥

For more details on these errors, see this check.

Results for commit 2da08f0.

@github-actions
Copy link

github-actions bot commented Sep 5, 2022

Unit Test Results (build & test)

517 tests  ±0   517 ✔️ ±0   8m 32s ⏱️ -58s
121 suites ±0       0 💤 ±0 
121 files   ±0       0 ❌ ±0 

Results for commit 2da08f0. ± Comparison against base commit 13f20ad.

shirshanka
shirshanka approved these changes Sep 6, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit d283e2b into datahub-project:master Sep 6, 2022
shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Sep 8, 2022
@treff7es @shirshanka
fix(ingest): presto-on-hive - customize filter query for postgres (da…
a065d73 
…tahub-project#5825)
shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Sep 8, 2022
@treff7es @shirshanka
fix(ingest): presto-on-hive - customize filter query for postgres (da…
c548f88 
…tahub-project#5825)
@treff7es treff7es deleted the mysql_filter_fix branch February 8, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szalai1 szalai1 szalai1 approved these changes

@anshbansal anshbansal anshbansal approved these changes

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@treff7es @shirshanka @anshbansal @szalai1