Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): profiling - memory usage reduction #5830

Merged
merged 2 commits into from
Sep 6, 2022
Merged

fix(ingest): profiling - memory usage reduction #5830

merged 2 commits into from
Sep 6, 2022

Conversation

shirshanka
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@shirshanka shirshanka added the ingestion PR or Issue related to the ingestion of metadata label Sep 5, 2022
treff7es
treff7es approved these changes Sep 5, 2022
View reviewed changes
Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions
Copy link

github-actions bot commented Sep 5, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       8 files         8 suites   52m 33s ⏱️
   671 tests    663 ✔️ 3 💤 3 ❌ 2 🔥
1 342 runs  1 329 ✔️ 6 💤 5 ❌ 2 🔥

For more details on these failures and errors, see this check.

Results for commit ce126c6.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 5, 2022

Unit Test Results (build & test)

517 tests  ±0   517 ✔️ ±0   8m 22s ⏱️ - 1m 8s
121 suites ±0       0 💤 ±0 
121 files   ±0       0 ❌ ±0 

Results for commit ce126c6. ± Comparison against base commit 13f20ad.

@shirshanka
Copy link
Contributor Author

failures seem legit, fixing and will reopen.

@shirshanka shirshanka closed this Sep 6, 2022
@shirshanka shirshanka reopened this Sep 6, 2022
@shirshanka shirshanka merged commit f4eea5d into datahub-project:master Sep 6, 2022
shirshanka added a commit to shirshanka/datahub that referenced this pull request Sep 8, 2022
@shirshanka
fix(ingest): profiling - memory usage reduction (datahub-project#5830)
ad3b7b4
shirshanka added a commit to shirshanka/datahub that referenced this pull request Sep 8, 2022
@shirshanka
fix(ingest): profiling - memory usage reduction (datahub-project#5830)
d951018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treff7es treff7es treff7es approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shirshanka @treff7es