fix(patch-entity-registry): Remove exception for entities with key aspects. #5831
Conversation
shirshanka
added
community-contribution
|
I thought I had the unit test passing locally, but it looks like I was mistaken. I added another commit that should fix the unit test. |
|
@RyanHolstien Should I be merging in the latest changes whenever I can? Since I am a first time contributor the automated checks do not run unless triggered by someone, and they'll need to be run again when I merge in the latest changes. This seems like it would cause a lot of unnecessary overhead trying to time it right. |
No you don't have to repeatedly merge unless there are actual merge conflicts that prevent merging 🙂 just haven't had a chance to review yet. Will take a look through. |
| // aspectSpecs.add(getAspectSpec(entity.getKeyAspect(), entitySpecBuilder)); | ||
| AspectSpec keyAspectSpec = buildAspectSpec(entity.getKeyAspect(), entitySpecBuilder); | ||
| log.info("Adding key aspect {} with spec {}", entity.getKeyAspect(), keyAspectSpec); | ||
| aspectSpecs.add(keyAspectSpec);; |
There was a problem hiding this comment.
Can you remove this second semi-colon? Otherwise lgtm
There was a problem hiding this comment.
Good catch. I'll remove it.
There was a problem hiding this comment.
Assuming there are no other changes needed, would you be able to merge the change in? I don't have write access.
…pects. (datahub-project#5831) * fix(patch-entity-registry): Remove exception for entities with key aspects. * test(patch-entity-registry): Fix failing unit test for entities with key aspect * test(patch-entity-registry): Fix checkstyle for PatchEntityRegistryTest.java * fix(patch-entity-registry): Remove duplicate semicolon. Co-authored-by: Parham Ghazanfari <[email protected]>
…pects. (datahub-project#5831) * fix(patch-entity-registry): Remove exception for entities with key aspects. * test(patch-entity-registry): Fix failing unit test for entities with key aspect * test(patch-entity-registry): Fix checkstyle for PatchEntityRegistryTest.java * fix(patch-entity-registry): Remove duplicate semicolon. Co-authored-by: Parham Ghazanfari <[email protected]>
Checklist