-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(java11) - convert most modules to java 11 #5836
refactor(java11) - convert most modules to java 11 #5836
Conversation
Sync with upstream
From upstream
Upstream sync
Upstream
Upstream
…va_11_nonexplicit
…va_11_nonexplicit
…va_11_nonexplicit
My question is more, what is the benefit of compiling datahub code with java 11 jdk? byte code improvements? Java 11 language features? Following #5875 all datahub images will run in Java 11 runtime with java 8 byte code. |
There are a couple benefits of compiling with jdk11 where possible. One of them are language features for sure. For example, I think that the most important reason is ultimately that many libraries are deprecating jdk8 support and without updating to jdk11 this locks DataHub into older versions of libraries. In turn, these older libraries may not contain important security fixes and newer functionality. |
Add wait for ES startup in tests
…va_11_nonexplicit
b1b8c95
to
bc08236
Compare
…and simplify ES healtcheck spark-smoke-test - add logging
bc08236
to
1f35ef2
Compare
…va_11_nonexplicit
…va_11_nonexplicit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR is one of two Java 11 options (other) - only merge one. This version converts modules to Java 11 where they are not tied to spark-lineage which requires Java 8. Unlike the other PR, there are no duplicate modules for Java 11 and Java 8, only one java version is chosen based on its usage by
spark-lineage
All modules except these are converted to java 11:
li-utils
metadata-models
test-models
metadata-integration:java:datahub-client
metadata-integration:java:spark-lineage
Checklist