Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(domains): adding 10,000+ text when domain list caps out elastic count capacity #5838

Merged
merged 4 commits into from
Sep 8, 2022
Merged

fix(domains): adding 10,000+ text when domain list caps out elastic count capacity #5838

merged 4 commits into from
Sep 8, 2022

Conversation

gabe-lyons
Copy link
Contributor

Adds clarity to domain list page for domains that have more than 10,000 elements

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

jjoyce0510
jjoyce0510 reviewed Sep 6, 2022
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only solves for one particular case. There are many such search surface areas in the app, should we consider doing this for all of them?

@github-actions
Copy link

github-actions bot commented Sep 6, 2022 •
edited
Loading

Unit Test Results (build & test)

517 tests  ±0   517 ✔️ ±0   9m 25s ⏱️ + 1m 2s
121 suites ±0       0 💤 ±0 
121 files   ±0       0 ❌ ±0 

Results for commit 84fff4d. ± Comparison against base commit aa146db.

♻️ This comment has been updated with latest results.

@gabe-lyons
Copy link
Contributor Author

@jjoyce0510 updated to cover groups

jjoyce0510
jjoyce0510 reviewed Sep 7, 2022
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

anshbansal
anshbansal approved these changes Sep 8, 2022
View reviewed changes
Copy link
Collaborator

@anshbansal anshbansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anshbansal anshbansal merged commit f411487 into datahub-project:master Sep 8, 2022
@anshbansal anshbansal added the product PR or Issue related to the DataHub UI/UX label Sep 8, 2022
hsheth2 pushed a commit to hsheth2/datahub that referenced this pull request Sep 8, 2022
@gabe-lyons @hsheth2
fix(domains): adding 10,000+ text when domain list caps out elastic c…
561882f 
…ount capacity (datahub-project#5838)
shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Sep 8, 2022
@gabe-lyons @shirshanka
fix(domains): adding 10,000+ text when domain list caps out elastic c…
7d54db3 
…ount capacity (datahub-project#5838)
shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Sep 8, 2022
@gabe-lyons @shirshanka
fix(domains): adding 10,000+ text when domain list caps out elastic c…
76faa36 
…ount capacity (datahub-project#5838)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 left review comments

@anshbansal anshbansal anshbansal approved these changes

Assignees
No one assigned
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabe-lyons @anshbansal @jjoyce0510