Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hooks): Add toggle for enabling/disabling platform event hook #5840

Merged
merged 1 commit into from
Sep 6, 2022
Merged

feat(hooks): Add toggle for enabling/disabling platform event hook #5840

merged 1 commit into from
Sep 6, 2022

Conversation

pedro93
Copy link
Collaborator

@pedro93 pedro93 commented Sep 6, 2022

Adds the possibility to skip MCL processor hooks.
Starts with adding toggle for Entity Change Events.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@pedro93 pedro93 self-assigned this Sep 6, 2022
@pedro93 pedro93 added the devops PR or Issue related to DataHub backend & deployment label Sep 6, 2022
@github-actions
Copy link

github-actions bot commented Sep 6, 2022

Unit Test Results (build & test)

517 tests  ±0   517 ✔️ ±0   8m 58s ⏱️ +35s
121 suites ±0       0 💤 ±0 
121 files   ±0       0 ❌ ±0 

Results for commit 9928e94. ± Comparison against base commit aa146db.

@RyanHolstien RyanHolstien merged commit 9434afc into datahub-project:master Sep 6, 2022
@RyanHolstien RyanHolstien deleted the disable-platform-event-hook branch September 6, 2022 19:54
shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Sep 8, 2022
@pedro93 @shirshanka
feat(hooks): Add toggle for enabling/disabling platform event hook (d…
bcfbae9 
…atahub-project#5840)
shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Sep 8, 2022
@pedro93 @shirshanka
feat(hooks): Add toggle for enabling/disabling platform event hook (d…
d5805f7 
…atahub-project#5840)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanHolstien RyanHolstien RyanHolstien approved these changes

@shirshanka shirshanka Awaiting requested review from shirshanka

Assignees

@pedro93 pedro93

Labels
devops PR or Issue related to DataHub backend & deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pedro93 @RyanHolstien