feat(inputs): improving clarity on inputs for dashboards #5841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjoyce0510
reviewed
Sep 6, 2022
| @@ -215,7 +204,13 @@ export class DashboardEntity implements Entity<Dashboard> { | |||
| statsSummary={data.statsSummary} | |||
| lastUpdatedMs={data.properties?.lastModified?.time} | |||
| createdMs={data.properties?.created?.time} | |||
| snippet={<ChartSnippet matchedFields={result.matchedFields} inputFields={data.inputFields} />} | |||
| snippet={ | |||
| <ChartSnippet | |||
There was a problem hiding this comment.
Why not use "DashboardSnippet"?
I guess this also works tho
jjoyce0510
approved these changes
Sep 6, 2022
shirshanka
pushed a commit
to shirshanka/datahub
that referenced
this pull request
Sep 8, 2022
shirshanka
pushed a commit
to shirshanka/datahub
that referenced
this pull request
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've received feedback that this inputs tabs can be confusing for dashboards given they are actually the aggregation of all inputs of all charts inside the dashboard. Adding clarity here by updating snippets and hiding the tab on dashboards.
Checklist