Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(smoke): add additional log in smoke test #5842

Merged
merged 1 commit into from
Sep 7, 2022
Merged

chore(smoke): add additional log in smoke test #5842

merged 1 commit into from
Sep 7, 2022

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Sep 6, 2022

Will help debug flakes like this one: https://github.com/datahub-project/datahub/runs/8213344841?check_suite_focus=true

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@hsheth2 hsheth2 requested a review from pedro93 September 6, 2022 19:33
@hsheth2 hsheth2 mentioned this pull request Sep 6, 2022
Merged
5 tasks
@github-actions
Copy link

github-actions bot commented Sep 6, 2022

Unit Test Results (build & test)

517 tests  ±0   517 ✔️ ±0   9m 16s ⏱️ -8s
121 suites ±0       0 💤 ±0 
121 files   ±0       0 ❌ ±0 

Results for commit f3272e3. ± Comparison against base commit 20138a3.

anshbansal
anshbansal approved these changes Sep 7, 2022
View reviewed changes
Copy link
Collaborator

@anshbansal anshbansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anshbansal anshbansal merged commit 13e411e into datahub-project:master Sep 7, 2022
@hsheth2 hsheth2 deleted the smoke-test-logs branch September 7, 2022 16:06
shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Sep 8, 2022
@hsheth2 @shirshanka
chore(smoke): add additional logs in smoke test (datahub-project#5842)
d2435c1 
Will help debug flakes like this one: https://github.com/datahub-project/datahub/runs/8213344841?check_suite_focus=true
shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Sep 8, 2022
@hsheth2 @shirshanka
chore(smoke): add additional logs in smoke test (datahub-project#5842)
959c66e 
Will help debug flakes like this one: https://github.com/datahub-project/datahub/runs/8213344841?check_suite_focus=true
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anshbansal anshbansal anshbansal approved these changes

@pedro93 pedro93 pedro93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hsheth2 @pedro93 @anshbansal