Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest): fix doc generation import ordering issue with postgres #5846

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Sep 7, 2022

Relying on the correct import directly, rather than going through SQLAlchemy's import wrapper (in their dialect.py) allows us to bypass this strange error in doc generation.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Relying on the correct import directly, rather than going through
SQLAlchemy's import wrapper (in their dialect.py) allows us to bypass
this strange error in doc generation.
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Sep 7, 2022
@github-actions
Copy link

github-actions bot commented Sep 7, 2022

Unit Test Results (metadata ingestion)

       8 files  ±0         8 suites  ±0   54m 25s ⏱️ -11s
   683 tests ±0     680 ✔️ +3  3 💤 ±0  0  - 1 
1 366 runs  ±0  1 360 ✔️ +3  6 💤 ±0  0  - 1 

Results for commit 6e7ea3c. ± Comparison against base commit 08622f2.

@github-actions
Copy link

github-actions bot commented Sep 7, 2022

Unit Test Results (build & test)

517 tests  ±0   517 ✔️ ±0   9m 22s ⏱️ + 1m 9s
121 suites ±0       0 💤 ±0 
121 files   ±0       0 ±0 

Results for commit 6e7ea3c. ± Comparison against base commit 08622f2.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@anshbansal anshbansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anshbansal anshbansal added the docs Issues and Improvements to docs label Sep 7, 2022
@anshbansal anshbansal merged commit abddc01 into datahub-project:master Sep 7, 2022
@hsheth2 hsheth2 deleted the postgres-docgen-bug branch September 7, 2022 16:48
shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Sep 8, 2022
…atahub-project#5846)

Relying on the correct import directly, rather than going through
SQLAlchemy's import wrapper (in their dialect.py) allows us to bypass
this strange error in doc generation.
shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Sep 8, 2022
…atahub-project#5846)

Relying on the correct import directly, rather than going through
SQLAlchemy's import wrapper (in their dialect.py) allows us to bypass
this strange error in doc generation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Issues and Improvements to docs ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants