Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): include urns in rest sink failure logs #5848

Merged
merged 1 commit into from
Sep 8, 2022
Merged

fix(ingest): include urns in rest sink failure logs #5848

merged 1 commit into from
Sep 8, 2022

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Sep 7, 2022

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Sep 7, 2022
@github-actions
Copy link

github-actions bot commented Sep 7, 2022

Unit Test Results (build & test)

517 tests  ±0   517 ✔️ ±0   9m 49s ⏱️ + 1m 36s
121 suites ±0       0 💤 ±0 
121 files   ±0       0 ❌ ±0 

Results for commit 4d9a8d4. ± Comparison against base commit 08622f2.

shirshanka
shirshanka approved these changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsheth2 hsheth2 merged commit eb57beb into datahub-project:master Sep 8, 2022
@hsheth2 hsheth2 deleted the report-failed-urns branch September 8, 2022 17:29
hsheth2 added a commit to hsheth2/datahub that referenced this pull request Sep 8, 2022
@hsheth2
fix(ingest): include urns in rest sink failure logs (datahub-project#…
f93ce6a 
…5848)
shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Sep 8, 2022
@hsheth2 @shirshanka
fix(ingest): include urns in rest sink failure logs (datahub-project#…
c5011f3 
…5848)
shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Sep 8, 2022
@hsheth2 @shirshanka
fix(ingest): include urns in rest sink failure logs (datahub-project#…
eff1eb9 
…5848)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @shirshanka