Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docker) Adds Sasl support to base ingestion image #5855

Merged
merged 2 commits into from
Sep 7, 2022
Merged

feat(docker) Adds Sasl support to base ingestion image #5855

merged 2 commits into from
Sep 7, 2022

Conversation

pedro93
Copy link
Collaborator

@pedro93 pedro93 commented Sep 7, 2022

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

anshbansal
anshbansal approved these changes Sep 7, 2022
View reviewed changes
Copy link
Collaborator

@anshbansal anshbansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

github-actions bot commented Sep 7, 2022

Unit Test Results (build & test)

517 tests  ±0   517 ✔️ ±0   8m 23s ⏱️ -51s
121 suites ±0       0 💤 ±0 
121 files   ±0       0 ❌ ±0 

Results for commit ab311fa. ± Comparison against base commit 13e411e.

@anshbansal anshbansal added the devops PR or Issue related to DataHub backend & deployment label Sep 7, 2022
@anshbansal anshbansal merged commit 42a847c into datahub-project:master Sep 7, 2022
@anshbansal anshbansal deleted the sasl-ingestion-base branch September 7, 2022 16:51
shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Sep 8, 2022
@pedro93 @shirshanka
feat(docker) Adds Sasl support to base ingestion image (datahub-proje…
fbdb2cd 
…ct#5855)

* feat(docker) Adds Sasl support to base ingestion image

* Add oracle changes
shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Sep 8, 2022
@pedro93 @shirshanka
feat(docker) Adds Sasl support to base ingestion image (datahub-proje…
6868400 
…ct#5855)

* feat(docker) Adds Sasl support to base ingestion image

* Add oracle changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anshbansal anshbansal anshbansal approved these changes

@treff7es treff7es Awaiting requested review from treff7es

Assignees
No one assigned
Labels
devops PR or Issue related to DataHub backend & deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pedro93 @anshbansal