Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(smoke-tests) Make smoke tests use standalone consumers #5856

Merged
merged 3 commits into from
Sep 8, 2022
Merged

feat(smoke-tests) Make smoke tests use standalone consumers #5856

merged 3 commits into from
Sep 8, 2022

Conversation

pedro93
Copy link
Collaborator

@pedro93 pedro93 commented Sep 7, 2022

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@anshbansal anshbansal added the devops PR or Issue related to DataHub backend & deployment label Sep 7, 2022
anshbansal
anshbansal approved these changes Sep 7, 2022
View reviewed changes
Copy link
Collaborator

@anshbansal anshbansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will wait for CI

@github-actions
Copy link

github-actions bot commented Sep 7, 2022 •
edited
Loading

Unit Test Results (build & test)

521 tests  +4   521 ✔️ +4   14m 27s ⏱️ + 5m 13s
122 suites +1       0 💤 ±0 
122 files   +1       0 ❌ ±0 

Results for commit 2341ac2. ± Comparison against base commit 13e411e.

♻️ This comment has been updated with latest results.

@anshbansal
Copy link
Collaborator

@pedro93 CI is not passing. Re-ran smoke tests already. Something is missing?

@pedro93
Copy link
Collaborator Author

pedro93 commented Sep 8, 2022

It seems GitHub ci does not build the images during the pr process? https://github.com/datahub-project/datahub/runs/8242276085?check_suite_focus=true

@anshbansal anshbansal merged commit 102754f into datahub-project:master Sep 8, 2022
@anshbansal anshbansal deleted the enable-standalone-consumers-tests branch September 8, 2022 11:04
hsheth2 pushed a commit to hsheth2/datahub that referenced this pull request Sep 8, 2022
@pedro93 @hsheth2
feat(smoke-tests) Make smoke tests use standalone consumers (datahub-…
851cdff 
…project#5856)
shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Sep 8, 2022
@pedro93 @shirshanka
feat(smoke-tests) Make smoke tests use standalone consumers (datahub-…
2fe87d1 
…project#5856)
shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Sep 8, 2022
@pedro93 @shirshanka
feat(smoke-tests) Make smoke tests use standalone consumers (datahub-…
af72f43 
…project#5856)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anshbansal anshbansal anshbansal approved these changes

Assignees
No one assigned
Labels
devops PR or Issue related to DataHub backend & deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pedro93 @anshbansal