fix(graphql) Fix null pointer exception when fetching entity aspect via graphql #5857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| resultRenderSpec.setDisplayName(renderSpec.getString("displayName")); | ||
| resultRenderSpec.setKey(renderSpec.getString("key")); | ||
| result.setRenderSpec(resultRenderSpec); | ||
| } | ||
|
|
||
| results.add(result); |
There was a problem hiding this comment.
is the correct behavior when the renderSpec is null to still return the result in the list of results? or should this be in the null check?
There was a problem hiding this comment.
yup I believe it's fair that it returns null for this piece if there is no renderSpec. It's already an optional field in case the aspect doesn't have a renderSpec
There was a problem hiding this comment.
Okay great thanks!
aditya-radhakrishnan
approved these changes
Sep 7, 2022
shirshanka
pushed a commit
to shirshanka/datahub
that referenced
this pull request
Sep 8, 2022
shirshanka
pushed a commit
to shirshanka/datahub
that referenced
this pull request
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if you query for aspects on an entity with
autoRenderAspects: falseyou end up getting a null pointer exception from theWeaklyTypedAspectsResolver. This fixes that.Checklist