Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): bigquery - Fixing sharded regexp pattern config #5861

Merged
merged 2 commits into from
Sep 7, 2022
Merged

fix(ingest): bigquery - Fixing sharded regexp pattern config #5861

merged 2 commits into from
Sep 7, 2022

Conversation

treff7es
Copy link
Contributor

@treff7es treff7es commented Sep 7, 2022

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@treff7es treff7es requested a review from rslanka September 7, 2022 20:08
rslanka
rslanka approved these changes Sep 7, 2022
View reviewed changes
Copy link
Contributor

@rslanka rslanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Sep 7, 2022
@github-actions
Copy link

github-actions bot commented Sep 7, 2022

Unit Test Results (metadata ingestion)

       8 files         8 suites   56m 6s ⏱️
   683 tests    680 ✔️ 3 💤 0 ❌
1 366 runs  1 360 ✔️ 6 💤 0 ❌

Results for commit 8236ce2.

@github-actions
Copy link

github-actions bot commented Sep 7, 2022

Unit Test Results (build & test)

517 tests  ±0   517 ✔️ ±0   9m 4s ⏱️ +43s
121 suites ±0       0 💤 ±0 
121 files   ±0       0 ❌ ±0 

Results for commit 8236ce2. ± Comparison against base commit 5a07745.

@rslanka rslanka merged commit f9917ea into datahub-project:master Sep 7, 2022
shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Sep 8, 2022
@treff7es @shirshanka
Fixing sharded regexp pattern config (datahub-project#5861)
eb2f9db
shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Sep 8, 2022
@treff7es @shirshanka
Fixing sharded regexp pattern config (datahub-project#5861)
3ac3328
@treff7es treff7es deleted the sharded_regexp_config_fix branch February 8, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rslanka rslanka rslanka approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@treff7es @rslanka