Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): remove dbt delete_tests_as_datasets option #5865

Merged
merged 1 commit into from
Sep 8, 2022
Merged

fix(ingest): remove dbt delete_tests_as_datasets option #5865

merged 1 commit into from
Sep 8, 2022

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Sep 7, 2022

This option was added for backwards compat and can be dropped now.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@hsheth2
fix(ingest): remove dbt delete_tests_as_datasets option
23f4175 
This option was added for backwards compat and can be dropped now.
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Sep 7, 2022
@github-actions
Copy link

github-actions bot commented Sep 8, 2022

Unit Test Results (build & test)

521 tests  ±0   519 ✔️ ±0   14m 21s ⏱️ -4s
122 suites ±0       0 💤 ±0 
122 files   ±0       2 ❌ ±0 

For more details on these failures, see this check.

Results for commit 23f4175. ± Comparison against base commit 86979e4.

@github-actions
Copy link

github-actions bot commented Sep 8, 2022

Unit Test Results (metadata ingestion)

       8 files         8 suites   58m 36s ⏱️
   683 tests    680 ✔️ 3 💤 0 ❌
1 366 runs  1 360 ✔️ 6 💤 0 ❌

Results for commit 23f4175.

rslanka
rslanka approved these changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@rslanka rslanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rslanka rslanka merged commit 2115d5b into datahub-project:master Sep 8, 2022
shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Sep 8, 2022
@hsheth2 @shirshanka
fix(ingest): remove dbt delete_tests_as_datasets option (datahub-pr…
e87954d 
…oject#5865)

This option was added for backwards compat and can be dropped now.
shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Sep 8, 2022
@hsheth2 @shirshanka
fix(ingest): remove dbt delete_tests_as_datasets option (datahub-pr…
e7be8ef 
…oject#5865)

This option was added for backwards compat and can be dropped now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rslanka rslanka rslanka approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @rslanka