Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(m1): preflight works with brew postgres@14 #5868

Merged
merged 1 commit into from
Sep 8, 2022
Merged

fix(m1): preflight works with brew postgres@14 #5868

merged 1 commit into from
Sep 8, 2022

Conversation

shirshanka
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@shirshanka shirshanka requested a review from treff7es September 8, 2022 07:48
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Sep 8, 2022
@github-actions
Copy link

github-actions bot commented Sep 8, 2022

Unit Test Results (build & test)

521 tests  ±0   521 ✔️ ±0   14m 10s ⏱️ -19s
122 suites ±0       0 💤 ±0 
122 files   ±0       0 ❌ ±0 

Results for commit da1dfcf. ± Comparison against base commit d911b15.

@github-actions
Copy link

github-actions bot commented Sep 8, 2022

Unit Test Results (metadata ingestion)

       8 files  ±0         8 suites  ±0   57m 52s ⏱️ - 1m 46s
   683 tests ±0     679 ✔️ ±0  3 💤 ±0  1 ❌ ±0 
1 366 runs  ±0  1 359 ✔️ ±0  6 💤 ±0  1 ❌ ±0 

For more details on these failures, see this check.

Results for commit da1dfcf. ± Comparison against base commit d911b15.

anshbansal
anshbansal approved these changes Sep 8, 2022
View reviewed changes
Copy link
Collaborator

@anshbansal anshbansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on M1 and works.

@anshbansal anshbansal merged commit b9068ff into datahub-project:master Sep 8, 2022
hsheth2 pushed a commit to hsheth2/datahub that referenced this pull request Sep 8, 2022
@shirshanka @hsheth2
fix(m1): preflight works with brew postgres@14 (datahub-project#5868)
c54f935
shirshanka added a commit to shirshanka/datahub that referenced this pull request Sep 8, 2022
@shirshanka
fix(m1): preflight works with brew postgres@14 (datahub-project#5868)
fbd98db
shirshanka added a commit to shirshanka/datahub that referenced this pull request Sep 8, 2022
@shirshanka
fix(m1): preflight works with brew postgres@14 (datahub-project#5868)
d121a8f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anshbansal anshbansal anshbansal approved these changes

@treff7es treff7es Awaiting requested review from treff7es

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shirshanka @anshbansal