-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ingestion) Add more info to glue entities #5874
feat(ingestion) Add more info to glue entities #5874
Conversation
Unit Test Results (metadata ingestion) 8 files ±0 8 suites ±0 56m 36s ⏱️ + 1m 45s Results for commit ccf0ae4. ± Comparison against base commit 15a33fa. This pull request removes 5 and adds 1 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
a1783dc
to
3d3c8ac
Compare
3d3c8ac
to
3bd8ceb
Compare
7969081
to
c1bd52e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a minor tweak around the mcp generation logic. Overall LGTM.
One thing before we can merge this: I need to check if the subType piece is case-sensitive - we have used table
elsewhere in the codebase but Table
here, so I want to verify that it won't cause any issues.
@hsheth2 thank you for the comment, I am afraid introduced changes are breaking the tests, there are fails which weren't there previously: https://github.com/datahub-project/datahub/actions/runs/3049282407/jobs/4915193424 - I would fix it but I am not sure I understand why they were introduced. |
That's my bad - fixed up the tests |
This PR adds subTypes=["Table"] to glue datasets (tables) and also ingest Description of glue database (similarly to Description of the tables).
Checklist