Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): remove dbt disable_dbt_node_creation and load_schema options #5877

Merged
merged 5 commits into from
Sep 9, 2022
Merged

fix(ingest): remove dbt disable_dbt_node_creation and load_schema options #5877

merged 5 commits into from
Sep 9, 2022

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Sep 8, 2022

These options are no longer needed now that we have support for sibling nodes.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions
Copy link

github-actions bot commented Sep 8, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       8 files  ±0         8 suites  ±0   52m 44s ⏱️ - 3m 34s
   685 tests +2     682 ✔️ +2  3 💤 ±0  0 ❌ ±0 
1 370 runs  +4  1 364 ✔️ +4  6 💤 ±0  0 ❌ ±0 

Results for commit acbbf2c. ± Comparison against base commit 2115d5b.

♻️ This comment has been updated with latest results.

shirshanka
shirshanka requested changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, but this probably deserves an entry in updating_datahub.md before we can merge

@github-actions
Copy link

github-actions bot commented Sep 8, 2022 •
edited
Loading

Unit Test Results (build & test)

521 tests  ±0   521 ✔️ ±0   14m 37s ⏱️ -22s
122 suites ±0       0 💤 ±0 
122 files   ±0       0 ❌ ±0 

Results for commit acbbf2c. ± Comparison against base commit 2115d5b.

♻️ This comment has been updated with latest results.

@shirshanka shirshanka added the ingestion PR or Issue related to the ingestion of metadata label Sep 8, 2022
@hsheth2 hsheth2 mentioned this pull request Sep 8, 2022
Merged
5 tasks
@hsheth2 hsheth2 requested a review from shirshanka September 8, 2022 22:47
shirshanka
shirshanka approved these changes Sep 9, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit 954397a into datahub-project:master Sep 9, 2022
@hsheth2 hsheth2 deleted the drop-delete_tests_as_datasets branch September 12, 2022 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @shirshanka