Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ingest): looker - improve defaults for usage extraction now that… #5893

Merged
merged 2 commits into from
Sep 9, 2022

Conversation

shirshanka
Copy link
Contributor

… connector is stable

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@shirshanka shirshanka requested a review from hsheth2 September 9, 2022 17:57
@github-actions
Copy link

github-actions bot commented Sep 9, 2022

Unit Test Results (metadata ingestion)

       8 files         8 suites   55m 26s ⏱️
   685 tests    682 ✔️ 3 💤 0
1 370 runs  1 364 ✔️ 6 💤 0

Results for commit 31366ee.

Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm once surya’s suggestion is done

@github-actions
Copy link

github-actions bot commented Sep 9, 2022

Unit Test Results (build & test)

571 tests  +60   571 ✔️ +61   14m 19s ⏱️ +14s
141 suites +21       0 💤 ±  0 
141 files   +21       0  -   1 

Results for commit 31366ee. ± Comparison against base commit 5a0154f.

@shirshanka shirshanka merged commit 5074035 into datahub-project:master Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants