Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(approval workflows): adding approval workflow docs #5896

Merged
merged 10 commits into from
Sep 27, 2022

Conversation

gabe-lyons
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@anshbansal anshbansal added the docs Issues and Improvements to docs label Sep 10, 2022
import FeatureAvailability from '@site/src/components/FeatureAvailability';

# Approval Workflows

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to make it clear that this functionality is currently incubating, only available for datasets.

@@ -0,0 +1,184 @@
import FeatureAvailability from '@site/src/components/FeatureAvailability';

# Approval Workflows
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to About DataHub Approval Workflows - this should help with SEO


## Overview

Keeping all your metadata properly classified can be hard work when you only have a limited number of trusted data stewards. With Acryl, you can source proposals of tags and glossary terms associated to datasets or dataset schema fields. These proposals may come from users with limited context or programatic processes using hueristics. Then, data stewards and data owners can go through them and only approve proposals they consider correct. This reduces the burden of your stewards and owners while increasing coverage.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we do With Managed DataHub instead of With Acryl? Our Feature Availability component calls it the former

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prop case Tags, Glossary Terms, Dataset, Dataset Schema

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressing!


Keeping all your metadata properly classified can be hard work when you only have a limited number of trusted data stewards. With Acryl, you can source proposals of tags and glossary terms associated to datasets or dataset schema fields. These proposals may come from users with limited context or programatic processes using hueristics. Then, data stewards and data owners can go through them and only approve proposals they consider correct. This reduces the burden of your stewards and owners while increasing coverage.

Approval workflows also cover the business glossary itself. This allows you to source glossary terms and glossary term description changes from across your organization while limiting who has final control over what gets in.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prop case Business Glossary & Glossary Term


Approval workflows also cover the business glossary itself. This allows you to source glossary terms and glossary term description changes from across your organization while limiting who has final control over what gets in.

## Using Approval Workflows
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 love this whole section

`urn:li:tag:<id>`

Glossary Term URNs have the following format:
urn:li:glossaryTerm:<id>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enclose with `` -- urn:li:glossaryTerm:<id>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch


Specific Metadata Entity types have additional sub-resources to which tags may be applied.
Today, this only applies for Dataset Metadata Entities, which have a "fields" sub-resource, with each field uniquely identified using a standard path format, reflecting its place within the Dataset's data schema.
To construct a field path, see Constructing Dataset Field Paths.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a link out to Constructing Dataset Field Paths?

Glossary Term URNs have the following format:
urn:li:glossaryTerm:<id>

These full identifiers can be copied from the entity pages of the Tag or Glossary Term.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a screenshot of how to copy URN from the entity page


Once we've constructed an Entity URN, any relevant sub-resource identifiers, and a Tag or Term URN, we're ready to propose! To do so, we'll use the DataHub GraphQL API.

In particular, we'll be using the proposeTag, proposeGlossaryTerm and proposeUpdateDescription Mutations, which have the following interface:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

edit: proposeTag, proposeGlossaryTerm, and proposeUpdateDescription

- Propose Glossary Terms - Allows to propose terms at the Entity level
- Propose Dataset Column Glossary Terms - Allows to propose terms at the Dataset Field level

To be able to see the proposals Tab you need the <strong>"View Metadata Proposals"</strong> PLATFORM privilege
Copy link
Collaborator

@maggiehays maggiehays Sep 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proposals Tab

- Manage Glossary Term Proposals
- Manage Dataset Column Tag Proposals
- Manage Dataset Column Term Proposals
These map directly to the 4 privileges for doing the proposals
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add in line break after list

@gabe-lyons
Copy link
Contributor Author

@maggiehays addressed!

@github-actions
Copy link

github-actions bot commented Sep 27, 2022

Unit Test Results (build & test)

584 tests  ±0   580 ✔️ ±0   13m 1s ⏱️ -4s
143 suites ±0       4 💤 ±0 
143 files   ±0       0 ±0 

Results for commit 1d788b0. ± Comparison against base commit 3eace64.

♻️ This comment has been updated with latest results.

@gabe-lyons gabe-lyons merged commit 63007cf into datahub-project:master Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Issues and Improvements to docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants