Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add sync status feature guide #5897

Merged
merged 5 commits into from
Oct 14, 2022

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Sep 9, 2022

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the docs Issues and Improvements to docs label Sep 9, 2022
@github-actions
Copy link

github-actions bot commented Sep 9, 2022

Unit Test Results (build & test)

597 tests  ±0   593 ✔️ ±0   12m 24s ⏱️ +44s
147 suites ±0       4 💤 ±0 
147 files   ±0       0 ±0 

Results for commit cf96736. ± Comparison against base commit 9d5851c.

♻️ This comment has been updated with latest results.

@shirshanka
Copy link
Contributor

looks like doc build failed

docs/sync-status.md Outdated Show resolved Hide resolved
docs/sync-status.md Outdated Show resolved Hide resolved
docs/sync-status.md Outdated Show resolved Hide resolved
docs/sync-status.md Outdated Show resolved Hide resolved
@hsheth2 hsheth2 requested a review from maggiehays October 3, 2022 17:50
@hsheth2 hsheth2 dismissed maggiehays’s stale review October 5, 2022 17:16

Addressed these concerns

@laulpogan
Copy link
Contributor

@shirshanka per @hsheth2 this PR is good to go, we just need your approval

@hsheth2 hsheth2 merged commit 8b85f70 into datahub-project:master Oct 14, 2022
@hsheth2 hsheth2 deleted the sync-status-doc branch October 14, 2022 22:07
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Issues and Improvements to docs docs-refresh
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants