Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ingest): make sink use type annotations #5899

Merged
merged 4 commits into from
Sep 11, 2022

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Sep 10, 2022

Overall this should reduce the amount of code required to define a sink type.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions
Copy link

github-actions bot commented Sep 10, 2022

Unit Test Results (metadata ingestion)

       8 files         8 suites   57m 50s ⏱️
   688 tests    682 ✔️ 3 💤 3
1 376 runs  1 364 ✔️ 6 💤 6

For more details on these failures, see this check.

Results for commit 368182d.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

Unit Test Results (build & test)

571 tests  ±0   571 ✔️ ±0   14m 29s ⏱️ -44s
141 suites ±0       0 💤 ±0 
141 files   ±0       0 ±0 

Results for commit 368182d. ± Comparison against base commit afa5888.

@anshbansal anshbansal added the ingestion PR or Issue related to the ingestion of metadata label Sep 10, 2022
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit 220ae0b into datahub-project:master Sep 11, 2022
@hsheth2 hsheth2 deleted the sink-dynamic branch December 15, 2022 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants