Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transformer): fix invalid lastModified.actor entry in transformers #5906

Merged

Conversation

mayurinehate
Copy link
Collaborator

@mayurinehate mayurinehate commented Sep 12, 2022

Usage of AuditStampClass.construct_with_defaults() introduced in this commit create AuditStamp with empty string actor urn, leading to invalid record. Reverting to auditStamp entry, that was used earlier.
Issue was reported on Slack

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions
Copy link

github-actions bot commented Sep 12, 2022

Unit Test Results (metadata ingestion)

       8 files  ±0         8 suites  ±0   54m 53s ⏱️ +2s
   709 tests ±0     706 ✔️ ±0  3 💤 ±0  0 ±0 
1 418 runs  ±0  1 412 ✔️ ±0  6 💤 ±0  0 ±0 

Results for commit 72934f9. ± Comparison against base commit 15a33fa.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 12, 2022

Unit Test Results (build & test)

571 tests  ±0   571 ✔️ ±0   14m 30s ⏱️ -22s
141 suites ±0       0 💤 ±0 
141 files   ±0       0 ±0 

Results for commit 72934f9. ± Comparison against base commit 15a33fa.

♻️ This comment has been updated with latest results.

@anshbansal anshbansal added the ingestion PR or Issue related to the ingestion of metadata label Sep 13, 2022
@mayurinehate mayurinehate force-pushed the fix_empty_actor_transformer branch from 4c2b424 to 72934f9 Compare September 14, 2022 05:21
@hsheth2 hsheth2 merged commit 8ead62d into datahub-project:master Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants