Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest): minor changes in snowflake-beta source, add basic tests #5910

Merged
merged 1 commit into from
Sep 12, 2022
Merged

feat(ingest): minor changes in snowflake-beta source, add basic tests #5910

merged 1 commit into from
Sep 12, 2022

Conversation

mayurinehate
Copy link
Collaborator

  • Reduce verbosity of source report. Report dropped columns only if profiling.report_dropped_profiles is set
  • some minor refractors for clarity and robustness
  • unit tests for snowflake-beta

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@mayurinehate
feat(ingest): minot changes in snowflake-beta source
d457bac 
- Reduce verbosity of source report. Report dropped columns only if `profiling.report_dropped_profiles` is set
- some minor refractors for clarity and robustness
- unit tests for snowflake-beta
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Sep 12, 2022
@github-actions
Copy link

Unit Test Results (metadata ingestion)

       8 files         8 suites   58m 13s ⏱️
   708 tests    705 ✔️ 3 💤 0 ❌
1 416 runs  1 410 ✔️ 6 💤 0 ❌

Results for commit d457bac.

@github-actions
Copy link

Unit Test Results (build & test)

571 tests  ±0   571 ✔️ ±0   14m 24s ⏱️ -14s
141 suites ±0       0 💤 ±0 
141 files   ±0       0 ❌ ±0 

Results for commit d457bac. ± Comparison against base commit db37dd2.

@mayurinehate mayurinehate changed the title feat(ingest): minot changes in snowflake-beta source, add basic tests feat(ingest): minor changes in snowflake-beta source, add basic tests Sep 12, 2022
shirshanka
shirshanka approved these changes Sep 12, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit aedf152 into datahub-project:master Sep 12, 2022
shirshanka pushed a commit to RyanHolstien/datahub that referenced this pull request Sep 12, 2022
@mayurinehate @shirshanka
feat(ingest): snowflake-beta - minor changes, tests (datahub-project#…
b02102a 
…5910)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mayurinehate @shirshanka