Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(airflow): prioritize conn_type over id-based type inference #5911

Merged
merged 2 commits into from
Sep 14, 2022

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Sep 12, 2022

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Sep 12, 2022
@github-actions
Copy link

Unit Test Results (metadata ingestion)

       8 files         8 suites   57m 19s ⏱️
   692 tests    689 ✔️ 3 💤 0
1 384 runs  1 378 ✔️ 6 💤 0

Results for commit 624eebe.

@github-actions
Copy link

Unit Test Results (build & test)

571 tests  ±0   571 ✔️ ±0   14m 56s ⏱️ +18s
141 suites ±0       0 💤 ±0 
141 files   ±0       0 ±0 

Results for commit 624eebe. ± Comparison against base commit db37dd2.

@hsheth2 hsheth2 requested a review from treff7es September 14, 2022 16:25
Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@treff7es treff7es merged commit 8f5b773 into datahub-project:master Sep 14, 2022
@hsheth2 hsheth2 deleted the airflow-hook-infer branch December 15, 2022 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants