Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: datahub_conn_id => conn_id in Airflow Integration #5920

Merged
merged 3 commits into from
Sep 15, 2022
Merged

docs: datahub_conn_id => conn_id in Airflow Integration #5920

merged 3 commits into from
Sep 15, 2022

Conversation

GyuhoonK
Copy link
Contributor

@GyuhoonK GyuhoonK commented Sep 13, 2022 •
edited
Loading

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

I read airflow integration(https://datahubproject.io/docs/lineage/airflow/#using-datahubs-airflow-lineage-plugin-new), and found that datahub_conn_id should be changed to conn_id.
I add some conversation with @treff7es in Slack (https://datahubspace.slack.com/archives/C029A3M079U/p1663069150243549?thread_ts=1662611232.747409&cid=C029A3M079U)

This is my first contribution..!
If something is wrong, plz let me know!
Thank you.

@github-actions github-actions bot added the docs Issues and Improvements to docs label Sep 13, 2022
@GyuhoonK GyuhoonK changed the title datahub_conn_id => conn_id datahub_conn_id => conn_id in Airflow Integration Sep 13, 2022
@GyuhoonK GyuhoonK changed the title datahub_conn_id => conn_id in Airflow Integration docs: datahub_conn_id => conn_id in Airflow Integration Sep 13, 2022
@GyuhoonK GyuhoonK closed this Sep 13, 2022
@GyuhoonK GyuhoonK deleted the docs(airflow) branch September 13, 2022 12:49
@GyuhoonK GyuhoonK restored the docs(airflow) branch September 13, 2022 12:50
@GyuhoonK GyuhoonK reopened this Sep 13, 2022
@maggiehays maggiehays added the community-contribution PR or Issue raised by member(s) of DataHub Community label Sep 13, 2022
@hsheth2 hsheth2 merged commit 4986eac into datahub-project:master Sep 15, 2022
@GyuhoonK GyuhoonK deleted the docs(airflow) branch September 22, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees

@hsheth2 hsheth2

Labels
community-contribution PR or Issue raised by member(s) of DataHub Community docs Issues and Improvements to docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GyuhoonK @hsheth2 @maggiehays