Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ingest): add CorpUser and CorpGroup to the Python SDK #5930

Conversation

ttaubermarshall-stripe
Copy link
Contributor

Makes it easy for DataHub users to ingest group and user information from external sources through Python.

Tested by adding examples to lineage_job_dataflow_new_api_verbose.py, running that locally, and verifying expected information appears in the UI.

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Sep 14, 2022
@anshbansal anshbansal added the community-contribution PR or Issue raised by member(s) of DataHub Community label Sep 14, 2022
@github-actions
Copy link

github-actions bot commented Sep 21, 2022

Unit Test Results (metadata ingestion)

       8 files         8 suites   58m 17s ⏱️
   719 tests    716 ✔️ 3 💤 0
1 440 runs  1 434 ✔️ 6 💤 0

Results for commit eb93edf.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 21, 2022

Unit Test Results (build & test)

584 tests   580 ✔️  13m 1s ⏱️
143 suites      4 💤
143 files        0

Results for commit eb93edf.

♻️ This comment has been updated with latest results.

@ttaubermarshall-stripe ttaubermarshall-stripe force-pushed the ttaubermarshall-corp-user-entity branch from ec7a6ad to 7ff332d Compare September 23, 2022 22:06
@shirshanka shirshanka requested a review from hsheth2 September 26, 2022 06:49
@hsheth2
Copy link
Collaborator

hsheth2 commented Oct 3, 2022

@ttaubermarshall-stripe - looks like there's a mypy issue

@ttaubermarshall-stripe
Copy link
Contributor Author

@ttaubermarshall-stripe - looks like there's a mypy issue

Sorry about that, should be fixed. Thanks for taking a look at this!

@hsheth2 hsheth2 changed the title feat(ingest): add support for CorpUser and CorpGroup to the Python api feat(ingest): add CorpUser and CorpGroup to the Python SDK Oct 4, 2022
@hsheth2 hsheth2 merged commit 6b83cab into datahub-project:master Oct 4, 2022
david-leifker pushed a commit to david-leifker/datahub that referenced this pull request Oct 6, 2022
@maggiehays maggiehays added the hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ label Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants