refactor(gms): Adding Java Entity Services #5931
Conversation
metadata-io/src/main/java/com/linkedin/metadata/entity/AspectUtils.java
Outdated
Show resolved
Hide resolved
metadata-io/src/main/java/com/linkedin/metadata/entity/AspectUtils.java
Outdated
Show resolved
Hide resolved
|
|
||
|
|
||
| @Slf4j | ||
| public class DomainService { |
There was a problem hiding this comment.
does it make sense to create an interface for these tag/term/owner/domain services that they all implement?
There was a problem hiding this comment.
I don't think so. No shared methods really.
If anything, a shared base class
There was a problem hiding this comment.
what if we replaced things like batchSetDomain with batchSet
There was a problem hiding this comment.
refactored common code into BaseService
| } | ||
|
|
||
| @VisibleForTesting | ||
| List<MetadataChangeProposal> buildRemoveGlossaryTermsProposals( |
There was a problem hiding this comment.
buildRemoveGlossaryTermsMetadataChangeProposals? Since proposal is an overloaded word
There was a problem hiding this comment.
oh interesting....
There was a problem hiding this comment.
i think in the context here... it should be okay. what im thinking for saas is that we'll build a ProposalService or ActionRequestService most likely to complement
jjoyce0510
force-pushed
the
jj--adding-entity-services
branch
from
996ac24 to
bc38c8f
Compare
metadata-io/src/main/java/com/linkedin/metadata/service/GlossaryTermService.java
Outdated
Show resolved
Hide resolved
metadata-io/src/main/java/com/linkedin/metadata/service/GlossaryTermService.java
Show resolved
Hide resolved
metadata-io/src/main/java/com/linkedin/metadata/service/GlossaryTermService.java
Outdated
Show resolved
Hide resolved
Summary
In this PR, we introduce handy and reusable service classes for Owners, Glossary Terms, Domains, and Tags. Currently, they allow you to bulk add and remove each of these items.
Specifically:
along with unit tests for each.
In future PRs, we will migrate resolvers to using these services.
Status
Ready to review
Checklist