Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): hide deprecated path_spec option from config #5944

Merged
merged 10 commits into from
Oct 4, 2022
Merged

fix(ingest): hide deprecated path_spec option from config #5944

merged 10 commits into from
Oct 4, 2022

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Sep 14, 2022 •
edited
Loading

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Sep 14, 2022
@github-actions
Copy link

github-actions bot commented Sep 14, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       8 files         8 suites   1h 0m 59s ⏱️
   719 tests    716 ✔️ 3 💤 0 ❌
1 440 runs  1 434 ✔️ 6 💤 0 ❌

Results for commit a4e8542.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 14, 2022 •
edited
Loading

Unit Test Results (build & test)

584 tests   580 ✔️  13m 19s ⏱️
143 suites      4 💤
143 files        0 ❌

Results for commit a4e8542.

♻️ This comment has been updated with latest results.

rslanka
rslanka approved these changes Sep 20, 2022
View reviewed changes
Copy link
Contributor

@rslanka rslanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hsheth2 hsheth2 marked this pull request as draft September 21, 2022 02:02
@hsheth2 hsheth2 marked this pull request as ready for review October 3, 2022 18:29
@hsheth2 hsheth2 merged commit 3c0f63c into datahub-project:master Oct 4, 2022
@hsheth2 hsheth2 deleted the s3-config-pathspec branch October 4, 2022 19:14
david-leifker pushed a commit to david-leifker/datahub that referenced this pull request Oct 6, 2022
@hsheth2 @david-leifker
fix(ingest): hide deprecated path_spec option from config (datahub-pr…
25d3931 
…oject#5944)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rslanka rslanka rslanka approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @rslanka