Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest): continue validation of s3 path_specs even if platform is set #5951

Merged
merged 2 commits into from
Sep 16, 2022

Conversation

mayurinehate
Copy link
Collaborator

Issue reported on Slack

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Sep 15, 2022
@github-actions
Copy link

Unit Test Results (build & test)

521 tests  ±0   515 ✔️ ±0   14m 16s ⏱️ +3s
122 suites ±0       0 💤 ±0 
122 files   ±0       6 ±0 

For more details on these failures, see this check.

Results for commit dff72ec. ± Comparison against base commit 66985335.

@github-actions
Copy link

Unit Test Results (metadata ingestion)

       8 files  ±0         8 suites  ±0   57m 34s ⏱️ + 1m 20s
   707 tests ±0     704 ✔️ +1  3 💤 ±0  0  - 1 
1 414 runs  ±0  1 408 ✔️ +1  6 💤 ±0  0  - 1 

Results for commit dff72ec. ± Comparison against base commit 66985335.

@hsheth2 hsheth2 merged commit a14617b into datahub-project:master Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants