Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(ingest): add example of ssl with mysql #5954

Merged
merged 1 commit into from
Sep 16, 2022
Merged

docs(ingest): add example of ssl with mysql #5954

merged 1 commit into from
Sep 16, 2022

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Sep 15, 2022

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Sep 15, 2022
jinlintt
jinlintt reviewed Sep 15, 2022
View reviewed changes
metadata-ingestion/docs/sources/mysql/mysql_recipe.yml
@@ -9,5 +9,12 @@ source:
username: root
password: example

# If you need to use SSL with MySQL:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is more general than just MySQL.
Maybe we can create a dedicated page that explains how to configure SSL connection parameters?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately the connect_args piece is db driver specific, so it doesn't generalize very well - we'll have to go through the sources one by one to add SSL examples

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Thank you!

@github-actions
Copy link

Unit Test Results (metadata ingestion)

       8 files         8 suites   1h 0m 48s ⏱️
   708 tests    705 ✔️ 3 💤 0 ❌
1 418 runs  1 412 ✔️ 6 💤 0 ❌

Results for commit 71d073b.

@github-actions
Copy link

Unit Test Results (build & test)

571 tests   571 ✔️  15m 25s ⏱️
141 suites      0 💤
141 files        0 ❌

Results for commit 71d073b.

anshbansal
anshbansal approved these changes Sep 16, 2022
View reviewed changes
Copy link
Collaborator

@anshbansal anshbansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anshbansal anshbansal merged commit 78f648a into datahub-project:master Sep 16, 2022
@hsheth2 hsheth2 deleted the mysql-ssl-example branch February 14, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinlintt jinlintt jinlintt approved these changes

@anshbansal anshbansal anshbansal approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hsheth2 @anshbansal @jinlintt