Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ingest): add support for aliases in plugin registry #5958

Merged

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Sep 15, 2022

Used for a deprecation warning + easy transition with snowflake-beta

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Used for a deprecation warning + easy transition with snowflake-beta
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Sep 15, 2022
@github-actions
Copy link

Unit Test Results (metadata ingestion)

       8 files  ±0         8 suites  ±0   59m 53s ⏱️ + 2m 46s
   708 tests ±0     705 ✔️ ±0  3 💤 ±0  0 ±0 
1 418 runs  ±0  1 412 ✔️ ±0  6 💤 ±0  0 ±0 

Results for commit 03960c1. ± Comparison against base commit f70bb20.

@github-actions
Copy link

Unit Test Results (build & test)

571 tests  ±0   571 ✔️ ±0   14m 30s ⏱️ +3s
141 suites ±0       0 💤 ±0 
141 files   ±0       0 ±0 

Results for commit 03960c1. ± Comparison against base commit f70bb20.

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit 937ab19 into datahub-project:master Sep 16, 2022
@hsheth2 hsheth2 deleted the snowflake-beta-backcompat branch February 14, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants