Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ownership-differ): standardise ownership change event payload #5967

Merged
merged 4 commits into from
Sep 22, 2022

Conversation

ngamanda
Copy link
Contributor

@ngamanda ngamanda commented Sep 16, 2022

Standardise payload for all ownership related change events to follow the DataHub documentation.

Specifically:

  • Adding missing ownerType in the parameters key for all Ownership Change Events
  • Updating 'Ownership type has changed' events to use OwnerChangeEvent instead of ChangeEvent

This was discovered while trying to leverage on the DataHub actions to respond to ownership changes. We needed to retrieve both the ownerUrn and ownerType from the action.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions
Copy link

github-actions bot commented Sep 16, 2022

Unit Test Results (build & test)

562 tests  ±0   562 ✔️ ±0   12m 50s ⏱️ +3s
139 suites ±0       0 💤 ±0 
139 files   ±0       0 ±0 

Results for commit ff15e60. ± Comparison against base commit f00e1f4.

♻️ This comment has been updated with latest results.

@anshbansal anshbansal added community-contribution PR or Issue raised by member(s) of DataHub Community product PR or Issue related to the DataHub UI/UX labels Sep 20, 2022
@jjoyce0510
Copy link
Collaborator

This looks great. Thank you!

@jjoyce0510
Copy link
Collaborator

Once this passes, will go ahead and merge.

@gabe-lyons gabe-lyons merged commit 63ef9c0 into datahub-project:master Sep 22, 2022
@ngamanda ngamanda deleted the ownership-differ branch October 3, 2022 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants