Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest): add platform instance to tableau #5978

Merged
merged 28 commits into from
Oct 14, 2022
Merged

feat(ingest): add platform instance to tableau #5978

merged 28 commits into from
Oct 14, 2022

Conversation

alaponin
Copy link
Contributor

@alaponin alaponin commented Sep 19, 2022 •
edited
Loading

This feature adds an optional platform instance to the Tableau connector to capture the uniqueness of the tableau server and site.

For testing, a new integration test was created.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Sep 19, 2022
@github-actions
Copy link

github-actions bot commented Sep 19, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       8 files  ±0         8 suites  ±0   58m 46s ⏱️ - 1m 20s
   738 tests +1     736 ✔️ +1  2 💤 ±0  0 ❌ ±0 
1 478 runs  +2  1 474 ✔️ +2  4 💤 ±0  0 ❌ ±0 

Results for commit 29d42c8. ± Comparison against base commit 521e61d.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 19, 2022 •
edited
Loading

Unit Test Results (build & test)

597 tests  ±0   593 ✔️ ±0   12m 5s ⏱️ -1s
147 suites ±0       4 💤 ±0 
147 files   ±0       0 ❌ ±0 

Results for commit 29d42c8. ± Comparison against base commit 521e61d.

♻️ This comment has been updated with latest results.

@alaponin alaponin changed the title Feature/tableau platform instance feat(ingest): add platform instance to tableau Sep 20, 2022
@alaponin alaponin marked this pull request as ready for review September 20, 2022 14:37
@anshbansal anshbansal added the community-contribution PR or Issue raised by member(s) of DataHub Community label Sep 20, 2022
hsheth2
hsheth2 approved these changes Oct 11, 2022
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Looks like there's an error + conflict in the tests - we recently made some big simplifications to the tests so you might need to regenerate the golden file.

@alaponin
Copy link
Contributor Author

LGTM!

Looks like there's an error + conflict in the tests - we recently made some big simplifications to the tests so you might need to regenerate the golden file.

Done, looks like there's a need for a workflow approval.

@hsheth2
Copy link
Collaborator

hsheth2 commented Oct 13, 2022

@alaponin thanks for fixing the merge conflicts! I've re-triggered the CI so hopefully we can merge this today :)

@alaponin
Copy link
Contributor Author

@alaponin thanks for fixing the merge conflicts! I've re-triggered the CI so hopefully we can merge this today :)

Fixed some linting issues. Hopefully the checks will pass now.

@hsheth2 hsheth2 merged commit bbdc185 into datahub-project:master Oct 14, 2022
@maggiehays maggiehays added the hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ label Oct 21, 2022
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
@alaponin @arnelaponin
@amanda-her @hsheth2 @cccs-tom
feat(ingest): add platform instance to tableau (datahub-project#5978)
a832f85 
Co-authored-by: Arne Laponin <[email protected]>
Co-authored-by: Amanda Hernando <[email protected]>
Co-authored-by: amanda-her <[email protected]>
Co-authored-by: Harshal Sheth <[email protected]>
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
@alaponin @arnelaponin
@amanda-her @hsheth2 @cccs-tom
feat(ingest): add platform instance to tableau (datahub-project#5978)
f32ecd8 
Co-authored-by: Arne Laponin <[email protected]>
Co-authored-by: Amanda Hernando <[email protected]>
Co-authored-by: amanda-her <[email protected]>
Co-authored-by: Harshal Sheth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

@mayurinehate mayurinehate Awaiting requested review from mayurinehate

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alaponin @hsheth2 @anshbansal @maggiehays @arnelaponin @amanda-her