Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): extend put command to support platform creation #5990

Merged
merged 4 commits into from
Sep 20, 2022
Merged

feat(cli): extend put command to support platform creation #5990

merged 4 commits into from
Sep 20, 2022

Conversation

shirshanka
Copy link
Contributor

Adds support to create a dataplatform entity using the cli.

e.g.

datahub put platform --name custom_platform --logo https://custom_platform_logo.png --display_name "Custom Platform"

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Sep 20, 2022
@shirshanka shirshanka requested a review from hsheth2 September 20, 2022 03:35
@github-actions
Copy link

Unit Test Results (metadata ingestion)

       8 files         8 suites   1h 0m 30s ⏱️
   709 tests    706 ✔️ 3 💤 0 ❌
1 420 runs  1 414 ✔️ 6 💤 0 ❌

Results for commit 395d6cd.

@github-actions
Copy link

Unit Test Results (build & test)

562 tests  ±0   562 ✔️ ±0   12m 57s ⏱️ -28s
139 suites ±0       0 💤 ±0 
139 files   ±0       0 ❌ ±0 

Results for commit 395d6cd. ± Comparison against base commit e24e5b6.

jjoyce0510
jjoyce0510 reviewed Sep 20, 2022
View reviewed changes
metadata-ingestion/src/datahub/cli/put_cli.py
help="Logo URL that must be reachable from the DataHub UI.",
required=True,
)
def platform(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really good! Can we have a docs update as part of this PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes you can!

@shirshanka shirshanka merged commit 8e8fb51 into datahub-project:master Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 left review comments

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shirshanka @hsheth2 @jjoyce0510