Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worked on the dynamic column width of stats table #5996

Merged
merged 7 commits into from
Sep 22, 2022
Merged

Worked on the dynamic column width of stats table #5996

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e723f88
Worked on the dynamic column width of stats table
Ankit-Keshari-Vituity Sep 20, 2022
e500dd6
Worked on the Entity title with ellipsis addition
Ankit-Keshari-Vituity Sep 21, 2022
d44bc5d
Merge branch 'master' into ui-bugs
Ankit-Keshari-Vituity Sep 21, 2022
e48a7ca
Changes on ui bugs
Ankit-Keshari-Vituity Sep 21, 2022
838b3ce
Added percentage Changes on ui bugs
Ankit-Keshari-Vituity Sep 21, 2022
eb23dba
resolved conflict
Ankit-Keshari-Vituity Sep 21, 2022
041f0a2
Worked on the PR comments
Ankit-Keshari-Vituity Sep 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 20 additions & 19 deletions datahub-web-react/src/app/entity/shared/tabs/Dataset/Schema/SchemaTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,16 +104,24 @@ export default function SchemaTable({
});

const fieldColumn = {
width: '22%',
title: 'Field',
dataIndex: 'fieldPath',
key: 'fieldPath',
width: 300,
render: schemaTitleRenderer,
filtered: true,
};

const descriptionColumn = {
width: '22%',
title: 'Description',
dataIndex: 'description',
key: 'description',
render: descriptionRender,
};

const tagColumn = {
width: 125,
width: '13%',
title: 'Tags',
dataIndex: 'globalTags',
key: 'tag',
Expand All @@ -122,33 +130,18 @@ export default function SchemaTable({
};

const termColumn = {
width: 125,
width: '13%',
title: 'Glossary Terms',
dataIndex: 'globalTags',
key: 'tag',
render: termRenderer,
onCell: onTagTermCell,
};

const usageColumn = {
width: 50,
title: 'Usage',
dataIndex: 'fieldPath',
key: 'usage',
render: usageStatsRenderer,
};
const descriptionColumn = {
title: 'Description',
dataIndex: 'description',
key: 'description',
render: descriptionRender,
width: 300,
};

const blameColumn = {
width: '10%',
dataIndex: 'fieldPath',
key: 'fieldPath',
width: 75,
render(record: SchemaField) {
return {
props: {
Expand All @@ -159,6 +152,14 @@ export default function SchemaTable({
},
};

const usageColumn = {
width: '10%',
title: 'Usage',
dataIndex: 'fieldPath',
key: 'usage',
render: usageStatsRenderer,
};

let allColumns: ColumnsType<ExtendedSchemaFields> = [fieldColumn, descriptionColumn, tagColumn, termColumn];

if (hasUsageStats) {
Expand Down
19 changes: 16 additions & 3 deletions datahub-web-react/src/app/preview/DefaultPreviewCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,13 @@ const EntityTitle = styled(Typography.Text)<{ $titleSizePx?: number }>`
}
`;

const CardEntityTitle = styled(EntityTitle)`
max-width: 350px;
white-space: nowrap;
overflow: hidden;
text-overflow: ellipsis;
`;

const PlatformText = styled(Typography.Text)`
font-size: 12px;
line-height: 20px;
Expand Down Expand Up @@ -271,9 +278,15 @@ export default function DefaultPreviewCard({
/>
<EntityTitleContainer>
<Link to={url}>
<EntityTitle onClick={onClick} $titleSizePx={titleSizePx}>
{name || ' '}
</EntityTitle>
{previewType === PreviewType.HOVER_CARD ? (
<CardEntityTitle onClick={onClick} $titleSizePx={titleSizePx}>
{name || ' '}
</CardEntityTitle>
) : (
<EntityTitle onClick={onClick} $titleSizePx={titleSizePx}>
{name || ' '}
</EntityTitle>
)}
</Link>
{deprecation?.deprecated && <DeprecationPill deprecation={deprecation} preview />}
{externalUrl && (
Expand Down