Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ingestion): Browse Paths Upgrade V2 Feast & Sagemaker #6002

Merged
merged 17 commits into from
Dec 21, 2022
Merged

refactor(ingestion): Browse Paths Upgrade V2 Feast & Sagemaker #6002

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
7c34418
Browse Paths Upgrade V2
jjoyce0510 Sep 21, 2022
09cd059
Fixing lint
jjoyce0510 Sep 21, 2022
49d7e03
Merge branch 'master' into jj--browse-paths-feast-sagemaker
jjoyce0510 Sep 23, 2022
bf9b598
Merge branch 'master' into jj--browse-paths-feast-sagemaker
jjoyce0510 Sep 27, 2022
b6e7473
Merge branch 'master' into jj--browse-paths-feast-sagemaker
jjoyce0510 Oct 6, 2022
7028182
Merge branch 'master' into jj--browse-paths-feast-sagemaker
jjoyce0510 Nov 15, 2022
614b446
Merge branch 'master' into jj--browse-paths-feast-sagemaker
hsheth2 Dec 2, 2022
a7d07bb
Merge branch 'master' into jj--browse-paths-feast-sagemaker
jjoyce0510 Dec 5, 2022
a711072
Fix browse path in golden file
jjoyce0510 Dec 15, 2022
0eb6486
Update sagemaker_mces_golden.json
jjoyce0510 Dec 15, 2022
d8fb535
Update sagemaker_mces_golden.json
jjoyce0510 Dec 16, 2022
3d96c5f
Update sagemaker_mces_golden.json
jjoyce0510 Dec 16, 2022
9188f08
Update sagemaker_mces_golden.json
jjoyce0510 Dec 16, 2022
51d85fd
Update models.py
jjoyce0510 Dec 16, 2022
a5dc0c2
addressing lint
jjoyce0510 Dec 19, 2022
ccac62b
Merge branch 'master' into jj--browse-paths-feast-sagemaker
jjoyce0510 Dec 20, 2022
de06773
Update models.py
jjoyce0510 Dec 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion metadata-ingestion/src/datahub/ingestion/source/aws/sagemaker_processors/feature_groups.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ def get_feature_group_wu(
feature_group_snapshot = MLFeatureTableSnapshot(
urn=builder.make_ml_feature_table_urn("sagemaker", feature_group_name),
aspects=[
BrowsePathsClass(paths=[f"/sagemaker/{feature_group_name}"]),
BrowsePathsClass(paths=["/sagemaker"]),
],
)

Expand Down
2 changes: 1 addition & 1 deletion metadata-ingestion/src/datahub/ingestion/source/aws/sagemaker_processors/jobs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,7 @@ def create_common_job_snapshot(
"jobType": job_type.value,
},
),
BrowsePathsClass(paths=[f"/{job_type.value}/{name}"]),
BrowsePathsClass(paths=[f"/{job_type.value}"]),
],
)

Expand Down
2 changes: 1 addition & 1 deletion metadata-ingestion/src/datahub/ingestion/source/aws/sagemaker_processors/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ def get_group_wu(
},
),
OwnershipClass(owners),
BrowsePathsClass(paths=[f"/sagemaker/{group_name}"]),
BrowsePathsClass(paths=["/sagemaker"]),
],
)

Expand Down
10 changes: 2 additions & 8 deletions metadata-ingestion/src/datahub/ingestion/source/feast.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,9 +301,7 @@ def _get_feature_view_workunit(self, feature_view: FeatureView) -> MetadataWorkU
feature_view_snapshot = MLFeatureTableSnapshot(
urn=builder.make_ml_feature_table_urn("feast", feature_view_name),
aspects=[
BrowsePathsClass(
paths=[f"/feast/{self.feature_store.project}/{feature_view_name}"]
),
BrowsePathsClass(paths=[f"/feast/{self.feature_store.project}"]),
StatusClass(removed=False),
],
)
Expand Down Expand Up @@ -342,11 +340,7 @@ def _get_on_demand_feature_view_workunit(
on_demand_feature_view_snapshot = MLFeatureTableSnapshot(
urn=builder.make_ml_feature_table_urn("feast", on_demand_feature_view_name),
aspects=[
BrowsePathsClass(
paths=[
f"/feast/{self.feature_store.project}/{on_demand_feature_view_name}"
]
),
BrowsePathsClass(paths=[f"/feast/{self.feature_store.project}"]),
StatusClass(removed=False),
],
)
Expand Down
4 changes: 2 additions & 2 deletions metadata-ingestion/tests/integration/feast/feast_repository_mces_golden.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@
{
"com.linkedin.pegasus2avro.common.BrowsePaths": {
"paths": [
"/feast/feature_store/feature_store.driver_hourly_stats"
"/feast/feature_store"
]
}
},
Expand Down Expand Up @@ -286,7 +286,7 @@
{
"com.linkedin.pegasus2avro.common.BrowsePaths": {
"paths": [
"/feast/feature_store/feature_store.transformed_conv_rate"
"/feast/feature_store"
]
}
},
Expand Down